You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What do we think about bindingValue being an attribute? I think it feels bad to have a property for this purpose, kind of like we have a #[Table] to avoid having a property
We can also make PrimaryKey the fallback bindable value if the attribute is not provided. It's a bit specialized in the framework code but it would feel better when consuming in userland (and we already have an exception for BackedEnum anyway)
What do we think about bindingValue being an attribute? I think it feels bad to have a property for this purpose, kind of like we have a #[Table] to avoid having a property
We can also make PrimaryKey the fallback bindable value if the attribute is not provided. It's a bit specialized in the framework code but it would feel better when consuming in userland (and we already have an exception for BackedEnum anyway)
You, sir, are a genius. First I'll have to clean up this PR some more though, because I broke a lot of things
brendt
changed the title
feat(http)!: support bindable values in uri generation
feat(database): primary key improvements
Aug 18, 2025
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brendt
changed the title
IsDatabaseModelCloses #1482
Closes #1519